Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Thanks for the heads up, there are indeed incredibly bad things in that project as linked by the top comment (with the simple word "bruh...") : https://github.com/crazywolf132/evo/blob/15d2ec6e821ef221961...

It is scary that someone can say it is "encrypting" a private key by applying a simple XOR.

Also :

"File-Based Index: We track file hashes in a small JSON index instead of re-hashing everything on every commit or switch. This makes commits and merges faster because Evo only re-hashes files if it notices a changed modtime"

Using modtime is not a good idea at all, this is very telling about how much author knows about different workflow. For those who don't know : you can have remotely mounted files where your machine and the server time is different (happens to me and realized that makefile is modtime based and it creates problem), also obviously clock can change and you do not want your version control system to be blind on changed file, ever.



He made a fix in https://github.com/crazywolf132/evo/commit/2452bec536d9b4d60... but he converted the indentation at the same time, and does not PRs at all. It's dangerous amateur stuff.


Maybe someone could politely explain it to him then instead of the condescending, alienating snark for which the computing community is infamous.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: