It wasn't anything special, but one I took a lot of personal enjoyment in was refactoring a god awful mess of untested, poorly written PHP that was at the core of the company's product. It was to the point that no one one the team wanted to touch it in case they'd break something. The CEO had written it and _hated_ any features being added (but always requested them) because it was so fragile.
I refactored it (on Director of Engineering's request) into discrete classes and functions that read well and were easily tested. Tested all our cases and even found existing bugs that were resolved in the move. This wasn't an incredible amount of code to begin with either. The initial file was probably 400-500 lines of code. This was not the feat of an incredible dev, it was just taking a minute to think and build it out. Most of the team could've also done the same in a day.
And then the CEO didn't like the idea of merging it, despite it being fully unit and integration test, along with a staging and canary testing plan.
I've heard they _still_ don't like to touch that file. The company isn't doing well. I don't think those two are correlated, but I do think the general mindset of the leadership does.
I refactored it (on Director of Engineering's request) into discrete classes and functions that read well and were easily tested. Tested all our cases and even found existing bugs that were resolved in the move. This wasn't an incredible amount of code to begin with either. The initial file was probably 400-500 lines of code. This was not the feat of an incredible dev, it was just taking a minute to think and build it out. Most of the team could've also done the same in a day.
And then the CEO didn't like the idea of merging it, despite it being fully unit and integration test, along with a staging and canary testing plan.
I've heard they _still_ don't like to touch that file. The company isn't doing well. I don't think those two are correlated, but I do think the general mindset of the leadership does.